Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1093823005: Use of base::StringPairs appropriately in server (Closed)

Created:
5 years, 8 months ago by payal.pandey
Modified:
5 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in server Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/fdae0200e90f6ca93fda8f992002b03629f75d15 Cr-Commit-Position: refs/heads/master@{#327241}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporated review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/server/http_server_response_info.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
payal.pandey
Use base::StringPairs instead. Please have a look.
5 years, 8 months ago (2015-04-27 07:23:09 UTC) #2
eroman
lgtm https://codereview.chromium.org/1093823005/diff/1/net/server/http_server_response_info.h File net/server/http_server_response_info.h (right): https://codereview.chromium.org/1093823005/diff/1/net/server/http_server_response_info.h#newcode40 net/server/http_server_response_info.h:40: typedef base::StringPairs Headers; the new style as I ...
5 years, 8 months ago (2015-04-27 21:39:08 UTC) #3
payal.pandey
Updated the CL with the specified changed. using Headers = base::StringPairs; Thanks for guiding feedback ...
5 years, 8 months ago (2015-04-28 05:34:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093823005/20001
5 years, 8 months ago (2015-04-28 05:34:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-28 06:48:03 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 06:48:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdae0200e90f6ca93fda8f992002b03629f75d15
Cr-Commit-Position: refs/heads/master@{#327241}

Powered by Google App Engine
This is Rietveld 408576698