Issue 1093803002: ScriptedAnimationController: factor out has-schedulable items predicate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1093803002: ScriptedAnimationController: factor out has-schedulable items predicate. (Closed)

Created:
5 years, 8 months ago by sof

Modified:
5 years, 8 months ago

Reviewers:
tkent

CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

ScriptedAnimationController: factor out has-schedulable items predicate. Common up the logic controlling the servicing/scheduling of animation events & actions. No change in functionality. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193983

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	Source/core/dom/ScriptedAnimationController.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	Source/core/dom/ScriptedAnimationController.cpp	View		2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. (minor thing noticed while reading the code.)

5 years, 8 months ago (2015-04-17 09:25:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093803002/1

5 years, 8 months ago (2015-04-18 12:43:54 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-18 14:07:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193983

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages