tabs: Make the vector in MockTabStripModelObserver own values instead of pointers.

tabs: Make the vector in MockTabStripModelObserver own values instead of pointers.

TEST=unit_tests
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158356

[sky, 2012-09-20 15:03:26]

http://codereview.chromium.org/10938027/diff/3003/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

http://codereview.chromium.org/10938027/diff/3003/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:407: std::vector<State*>
states_;
If you're going to do anything, make this contain values rather than pointers.

[tfarina, 2012-09-21 01:18:55]

http://codereview.chromium.org/10938027/diff/3003/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

http://codereview.chromium.org/10938027/diff/3003/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:407: std::vector<State*>
states_;
On 2012/09/20 15:03:26, sky wrote:
> If you're going to do anything, make this contain values rather than pointers.

Done.

[sky, 2012-09-21 16:12:01]

http://codereview.chromium.org/10938027/diff/16001/chrome/browser/ui/tabs/tab...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

http://codereview.chromium.org/10938027/diff/16001/chrome/browser/ui/tabs/tab...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:318:
EXPECT_EQ(state.src_contents, s.src_contents);
Hm. This function is weird. It should either have the EXPECTs and no return
value, or have a return value and no EXPECTs. But both is just wrong.

[tfarina, 2012-09-21 20:11:18]

http://codereview.chromium.org/10938027/diff/16001/chrome/browser/ui/tabs/tab...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

http://codereview.chromium.org/10938027/diff/16001/chrome/browser/ui/tabs/tab...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:318:
EXPECT_EQ(state.src_contents, s.src_contents);
On 2012/09/21 16:12:01, sky wrote:
> Hm. This function is weird. It should either have the EXPECTs and no return
> value, or have a return value and no EXPECTs. But both is just wrong.

Done.

[sky, 2012-09-21 20:19:50]

Nice. LGTM

[tfarina, 2012-09-21 20:41:39]

CL description updated.