Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Side by Side Diff: src/hydrogen-instructions.h

Issue 10938016: Fix lost arguments dropping in HLeaveInlined. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jakob Kummerow. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 FunctionLiteral* function_; 1465 FunctionLiteral* function_;
1466 CallKind call_kind_; 1466 CallKind call_kind_;
1467 InliningKind inlining_kind_; 1467 InliningKind inlining_kind_;
1468 Variable* arguments_var_; 1468 Variable* arguments_var_;
1469 ZoneList<HValue*>* arguments_values_; 1469 ZoneList<HValue*>* arguments_values_;
1470 }; 1470 };
1471 1471
1472 1472
1473 class HLeaveInlined: public HTemplateInstruction<0> { 1473 class HLeaveInlined: public HTemplateInstruction<0> {
1474 public: 1474 public:
1475 explicit HLeaveInlined(bool arguments_pushed) 1475 HLeaveInlined() { }
1476 : arguments_pushed_(arguments_pushed) { }
1477 1476
1478 virtual Representation RequiredInputRepresentation(int index) { 1477 virtual Representation RequiredInputRepresentation(int index) {
1479 return Representation::None(); 1478 return Representation::None();
1480 } 1479 }
1481 1480
1482 bool arguments_pushed() {
1483 return arguments_pushed_;
1484 }
1485
1486 DECLARE_CONCRETE_INSTRUCTION(LeaveInlined) 1481 DECLARE_CONCRETE_INSTRUCTION(LeaveInlined)
1487
1488 private:
1489 bool arguments_pushed_;
1490 }; 1482 };
1491 1483
1492 1484
1493 class HPushArgument: public HUnaryOperation { 1485 class HPushArgument: public HUnaryOperation {
1494 public: 1486 public:
1495 explicit HPushArgument(HValue* value) : HUnaryOperation(value) { 1487 explicit HPushArgument(HValue* value) : HUnaryOperation(value) {
1496 set_representation(Representation::Tagged()); 1488 set_representation(Representation::Tagged());
1497 } 1489 }
1498 1490
1499 virtual Representation RequiredInputRepresentation(int index) { 1491 virtual Representation RequiredInputRepresentation(int index) {
(...skipping 3789 matching lines...) Expand 10 before | Expand all | Expand 10 after
5289 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex); 5281 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex);
5290 }; 5282 };
5291 5283
5292 5284
5293 #undef DECLARE_INSTRUCTION 5285 #undef DECLARE_INSTRUCTION
5294 #undef DECLARE_CONCRETE_INSTRUCTION 5286 #undef DECLARE_CONCRETE_INSTRUCTION
5295 5287
5296 } } // namespace v8::internal 5288 } } // namespace v8::internal
5297 5289
5298 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 5290 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698