Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10938016: Fix lost arguments dropping in HLeaveInlined. (Closed)

Created:
8 years, 3 months ago by Michael Starzinger
Modified:
8 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix lost arguments dropping in HLeaveInlined. This fixes HleaveInlined to correctly drop pushed arguments on all code paths and addresses a corner case where the arguments stack height mismatched at an OSR entry point. R=jkummerow@chromium.org BUG=chromium:150545 TEST=mjsunit/regress/regress-crbug-150545 Committed: https://code.google.com/p/v8/source/detail?r=12543

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -42 lines) Patch
M src/arm/lithium-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -9 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-150545.js View 1 1 chunk +21 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 3 months ago (2012-09-18 16:20:21 UTC) #1
Jakob Kummerow
LGTM with a question. https://chromiumcodereview.appspot.com/10938016/diff/1/test/mjsunit/regress/regress-crbug-150545.js File test/mjsunit/regress/regress-crbug-150545.js (right): https://chromiumcodereview.appspot.com/10938016/diff/1/test/mjsunit/regress/regress-crbug-150545.js#newcode46 test/mjsunit/regress/regress-crbug-150545.js:46: while (--iterations > 0); why ...
8 years, 3 months ago (2012-09-19 07:51:12 UTC) #2
Michael Starzinger
8 years, 3 months ago (2012-09-19 08:12:26 UTC) #3
Addressed comments. Landing.

https://chromiumcodereview.appspot.com/10938016/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-crbug-150545.js (right):

https://chromiumcodereview.appspot.com/10938016/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-crbug-150545.js:46: while (--iterations > 0);
On 2012/09/19 07:51:12, Jakob wrote:
> why not this:
> 
> while (%GetOptimizationStatus(outer) == 2);
> 
> That would loop exactly until the function gets optimized, and you wouldn't
need
> the fixed iteration count.

Done.

Powered by Google App Engine
This is Rietveld 408576698