Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: runtime/bin/process.dart

Issue 10938010: Switch from interfaces to abstract classes in dart:io. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Add test binaries. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/path_impl.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.dart
diff --git a/runtime/bin/process.dart b/runtime/bin/process.dart
index c699670a291105a21818924f5e1f7cc0f798c347..f9e7e276e602f57d7828604f2ab6df38030a61f0 100644
--- a/runtime/bin/process.dart
+++ b/runtime/bin/process.dart
@@ -99,14 +99,14 @@ class Process {
abstract void set onError(void callback(e));
/**
- * On Windows, [kill] kills the process, ignoring the [signal] flag. On
- * Posix systems, [kill] sends [signal] to the process. Depending on the
- * signal giving, it'll have different meanings. The default [signal] to
- * send is [:ProcessSignal.SIGTERM:]. When the process terminates as a result
- * of calling [kill] [onExit] is called. If the kill operation fails,
- * [onError] is called.
+ * On Windows, [kill] kills the process, ignoring the [signal]
+ * flag. On Posix systems, [kill] sends [signal] to the
+ * process. Depending on the signal giving, it'll have different
+ * meanings. When the process terminates as a result of calling
+ * [kill] [onExit] is called. If the kill operation fails, [onError]
+ * is called.
*/
- abstract void kill([ProcessSignal signal]);
+ abstract void kill([ProcessSignal signal = ProcessSignal.SIGTERM]);
/**
* Terminates the streams of a process. [close] must be called on a
@@ -125,7 +125,7 @@ class Process {
* [ProcessResult] represents the result of running a non-interactive
* process started with [:Process.run:].
*/
-interface ProcessResult {
+abstract class ProcessResult {
/**
* Exit code for the process.
*/
@@ -229,7 +229,7 @@ class ProcessSignal {
class ProcessException implements Exception {
- const ProcessException([String this.message, int this.errorCode = 0]);
+ const ProcessException([String this.message = "", int this.errorCode = 0]);
String toString() => "ProcessException: $message ($errorCode)";
/**
« no previous file with comments | « runtime/bin/path_impl.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698