runtime/bin/http_impl.dart - Issue 10938010: Switch from interfaces to abstract classes in dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_impl.dart

Issue 10938010: Switch from interfaces to abstract classes in dart:io. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Add test binaries. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/http_impl.dart

diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart

index 31c3fac0375ec7af110ad3f5838bd8f7fec0fc9b..ecebe4c243e7c33245022dbc15be1afa23a59d52 100644

--- a/runtime/bin/http_impl.dart

+++ b/runtime/bin/http_impl.dart

@@ -427,8 +427,8 @@ class _HeaderValue implements HeaderValue {

class _ContentType extends _HeaderValue implements ContentType {

- _ContentType([String primaryType = "", String subType = ""])

- : _primaryType = primaryType, _subType = subType;

+ _ContentType(String primaryType, String subType)

+ : _primaryType = primaryType, _subType = subType, super("");

_ContentType.fromString(String value) : super.fromString(value);

« no previous file with comments | « runtime/bin/http.dart ('k') | runtime/bin/input_stream.dart » ('j') | no next file with comments »