Index: runtime/bin/process.dart |
diff --git a/runtime/bin/process.dart b/runtime/bin/process.dart |
index c699670a291105a21818924f5e1f7cc0f798c347..9cb3bfdd2bbc9ccd6c73990dfec719f0e718ace9 100644 |
--- a/runtime/bin/process.dart |
+++ b/runtime/bin/process.dart |
@@ -32,7 +32,7 @@ class Process { |
*/ |
static Process start(String executable, |
List<String> arguments, |
- [ProcessOptions options]) { |
+ [ProcessOptions options = null]) { |
Søren Gjesse
2012/09/18 09:34:16
Isn't null the default default value for optional
Mads Ager (google)
2012/09/18 10:46:39
Yes, it is redundant. Removed.
|
return new _Process.start(executable, arguments, options); |
} |
@@ -49,7 +49,7 @@ class Process { |
*/ |
static Future<ProcessResult> run(String executable, |
List<String> arguments, |
- [ProcessOptions options]) { |
+ [ProcessOptions options = null]) { |
Søren Gjesse
2012/09/18 09:34:16
"= null" needed?
Mads Ager (google)
2012/09/18 10:46:39
Done.
|
return _Process.run(executable, arguments, options); |
} |
@@ -106,7 +106,7 @@ class Process { |
* of calling [kill] [onExit] is called. If the kill operation fails, |
* [onError] is called. |
*/ |
- abstract void kill([ProcessSignal signal]); |
+ abstract void kill([ProcessSignal signal = ProcessSignal.SIGTERM]); |
/** |
* Terminates the streams of a process. [close] must be called on a |
@@ -125,7 +125,7 @@ class Process { |
* [ProcessResult] represents the result of running a non-interactive |
* process started with [:Process.run:]. |
*/ |
-interface ProcessResult { |
+abstract class ProcessResult { |
/** |
* Exit code for the process. |
*/ |
@@ -229,7 +229,7 @@ class ProcessSignal { |
class ProcessException implements Exception { |
- const ProcessException([String this.message, int this.errorCode = 0]); |
+ const ProcessException([String this.message = "", int this.errorCode = 0]); |
String toString() => "ProcessException: $message ($errorCode)"; |
/** |