Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java

Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address eroman's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
index cddd64d73e993d4dc40c32ed56a9c490174c570b..5e79584e186b2279617357814ac3959b70f77822 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
@@ -56,13 +56,16 @@ public abstract class UrlRequestContext {
public abstract void shutdown();
/**
- * Starts NetLog logging to a file. The NetLog capture mode used is
- * NetLogCaptureMode::Default().
+ * Starts NetLog logging to a file. The NetLog capture mode used is either
+ * NetLogCaptureMode::Default() or NetLogCaptureMode::IncludeSocketBytes().
mef 2015/05/06 21:47:28 I would explicitly specify that IncludeSocketBytes
kallasjoki 2015/05/07 10:51:27 Done.
* @param fileName The complete file path. It must not be empty. If file
* exists, it is truncated before starting. If actively logging,
* this method is ignored.
+ * @param logAll {@code true} to use the
+ * NetLogCaptureMode::IncludeSocketBytes() logging level. If
+ * false, NetLogCaptureMode::Default() is used instead.
*/
- public abstract void startNetLogToFile(String fileName);
+ public abstract void startNetLogToFile(String fileName, boolean logAll);
/**
* Stops NetLog logging and flushes file to disk. If a logging session is

Powered by Google App Engine
This is Rietveld 408576698