components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java - Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a doc comment that didn't get properly updated Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java ('K') | « components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java » ('j') | components/cronet/android/url_request_context_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

index 66c32c0523c804103399c785f4a671f74ed6d455..0ce78c50c532ead16864be6554747c29731b7fe4 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

@@ -277,7 +277,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

// Start NetLog immediately after the request context is created to make

// sure that the call won't crash the app even when the native request

// context is not fully initialized. See crbug.com/470196.

- requestContext.startNetLogToFile(file.getPath());

+ requestContext.startNetLogToFile(file.getPath(), false);

// Start a request.

TestUrlRequestListener listener = new TestUrlRequestListener();

@@ -307,7 +307,8 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

getInstrumentation().getTargetContext()));

File file = File.createTempFile("cronet", "json", directory);

try {

- mActivity.mUrlRequestContext.startNetLogToFile(file.getPath());

+ mActivity.mUrlRequestContext.startNetLogToFile(file.getPath(),

+ false);

fail("Should throw an exception.");

} catch (Exception e) {

assertEquals("Context is shut down.", e.getMessage());

@@ -324,10 +325,10 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

getInstrumentation().getTargetContext()));

File file = File.createTempFile("cronet", "json", directory);

// Start NetLog multiple times.

- mActivity.mUrlRequestContext.startNetLogToFile(file.getPath());

+ mActivity.mUrlRequestContext.startNetLogToFile(file.getPath(), false);

// Start a request.

TestUrlRequestListener listener = new TestUrlRequestListener();

UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(

@@ -348,7 +349,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

File directory = new File(PathUtils.getDataDirectory(

getInstrumentation().getTargetContext()));

File file = File.createTempFile("cronet", "json", directory);

- mActivity.mUrlRequestContext.startNetLogToFile(file.getPath());

+ mActivity.mUrlRequestContext.startNetLogToFile(file.getPath(), false);

// Start a request.

TestUrlRequestListener listener = new TestUrlRequestListener();

UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(