Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a doc comment that didn't get properly updated Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
index e7f7968b70dbdeb33a6619cb890420ceac9f7ec4..5509a683ab9e57dbc71d02326c23c8c96581bc1a 100644
--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
@@ -78,14 +78,18 @@ public class ChromiumUrlRequestContext {
}
/**
- * Starts NetLog logging to a file. The NetLog capture mode is
- * NetLogCaptureMode::Default().
+ * Starts NetLog logging to a file. The NetLog capture mode is either
+ * NetLogCaptureMode::Default() or NetLogCaptureMode::IncludeSocketBytes().
* @param fileName The complete file path. It must not be empty. If file
* exists, it is truncated before starting. If actively logging,
* this method is ignored.
+ * @param logAll {@code true} to use the NetLogCaptureMode::Default()
eroman 2015/05/06 17:34:19 This comment is reversed. true=IncludeSocketBytes,
kallasjoki 2015/05/06 17:47:08 Done. (I got them completely flipped when adjustin
+ * logging level. If false,
+ * NetLogCaptureMode::IncludeSocketBytes() is used instead.
*/
- public void startNetLogToFile(String fileName) {
- nativeStartNetLogToFile(mChromiumUrlRequestContextAdapter, fileName);
+ public void startNetLogToFile(String fileName, boolean logAll) {
+ nativeStartNetLogToFile(mChromiumUrlRequestContextAdapter, fileName,
+ logAll);
}
/**
@@ -150,7 +154,8 @@ public class ChromiumUrlRequestContext {
private native String nativeGetStatisticsJSON(String filter);
private native void nativeStartNetLogToFile(
- long chromiumUrlRequestContextAdapter, String fileName);
+ long chromiumUrlRequestContextAdapter, String fileName,
+ boolean logAll);
private native void nativeStopNetLog(long chromiumUrlRequestContextAdapter);

Powered by Google App Engine
This is Rietveld 408576698