components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java - Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java ('k') | components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

index 14ba209d711e93d9932a1a20638d82d9c00e6bc6..a1bf213913ca8c04a8f4e548e20d37e1d1d5bdd0 100644

--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

@@ -64,8 +64,12 @@ public abstract class HttpUrlRequestFactory {

* application temporary directory. |fileName| must not be empty. Log may

* contain user's personal information (PII). If the file exists it is

* truncated before starting. If actively logging the call is ignored.

+ * @param fileName The complete file path. It must not be empty. If file

+ * exists, it is truncated before starting.

+ * @param logAll {@code true} to also include all transferred bytes in the

+ * log.

- public abstract void startNetLogToFile(String fileName);

+ public abstract void startNetLogToFile(String fileName, boolean logAll);

/**

* Stops NetLog logging and flushes file to disk. If a logging session is