Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 1093793002: Allow setting Cronet NetLog level to LOG_ALL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
index f0207ec822c77549706197060b93ad19e373af9a..067406bb7c8b51635c4312eab7d1304c72521d93 100644
--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
@@ -77,14 +77,17 @@ public class ChromiumUrlRequestContext {
}
/**
- * Starts NetLog logging to a file. The NetLog log level used is
- * LOG_ALL_BUT_BYTES.
+ * Starts NetLog logging to a file. The NetLog log level used is either
+ * LOG_STRIP_PRIVATE_DATA or LOG_ALL.
eroman 2015/04/17 21:35:10 Note that LOG_STRIP_PRIVATE_DATA will soon be name
kallasjoki 2015/05/06 13:58:56 Acknowledged.
* @param fileName The complete file path. It must not be empty. If file
* exists, it is truncated before starting. If actively logging,
* this method is ignored.
+ * @param logAll {@code true} to use the LOG_ALL logging level. If false,
+ * LOG_STRIP_PRIVATE_DATA is used instead.
*/
- public void startNetLogToFile(String fileName) {
- nativeStartNetLogToFile(mChromiumUrlRequestContextAdapter, fileName);
+ public void startNetLogToFile(String fileName, boolean logAll) {
+ nativeStartNetLogToFile(mChromiumUrlRequestContextAdapter, fileName,
+ logAll);
}
/**
@@ -140,7 +143,8 @@ public class ChromiumUrlRequestContext {
private native String nativeGetStatisticsJSON(String filter);
private native void nativeStartNetLogToFile(
- long chromiumUrlRequestContextAdapter, String fileName);
+ long chromiumUrlRequestContextAdapter, String fileName,
+ boolean logAll);
private native void nativeStopNetLog(long chromiumUrlRequestContextAdapter);

Powered by Google App Engine
This is Rietveld 408576698