Allow setting Cronet NetLog level to LOG_ALL

components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.content.Context;
 import android.util.Log;
 
 import java.lang.reflect.Constructor;
@@ skipping 46 matching lines @@
      */
     public abstract HttpUrlRequest createRequest(String url,
             int requestPriority, Map<String, String> headers,
             WritableByteChannel channel, HttpUrlRequestListener listener);
 
     /**
      * Starts NetLog logging to a file named |fileName| in the
      * application temporary directory. |fileName| must not be empty. Log may
      * contain user's personal information (PII). If the file exists it is
      * truncated before starting. If actively logging the call is ignored.
+     * @param fileName The complete file path. It must not be empty. If file
+     *            exists, it is truncated before starting.
+     * @param logAll {@code true} to also include all transferred bytes in the
+     *            log.
      */
-    public abstract void startNetLogToFile(String fileName);
+    public abstract void startNetLogToFile(String fileName, boolean logAll);

[miloslav, 2015/04/17 14:15:03]

Would making this an int (the actual log level passed) give us more flexibility?

[eroman, 2015/04/17 21:35:10]

I am in favor of a boolean rather than an integer.

For starters, I think it is simpler to just have default+all modes exposed.
Secondly I am removing the integer based LogLevel in favor of a "CaptureMode"
class in https://codereview.chromium.org/1059843002/ so using an integer is not
going to work as well following that change.

[kallasjoki, 2015/05/06 13:58:57]

I've kept it as the boolean default-or-all choice, since that seems to fill our
immediately foreseeable needs, and exposing the whole NetLogCaptureMode logic to
the Java side seems like extra complexity.

 
     /**
      * Stops NetLog logging and flushes file to disk. If a logging session is
      * not in progress this call is ignored.
      */
     public abstract void stopNetLog();
 
     private static HttpUrlRequestFactory createChromiumFactory(
             Context context, UrlRequestContextConfig config) {
         HttpUrlRequestFactory factory = null;
@@ skipping 13 matching lines @@
         } catch (ClassNotFoundException e) {
             // Leave as null
         } catch (Exception e) {
             throw new IllegalStateException(
                     "Cannot instantiate: " + CHROMIUM_URL_REQUEST_FACTORY,
                     e);
         }
         return factory;
     }
 }