Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1093783002: Revert of Refactor compilation dependency handling. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor compilation dependency handling. (patchset #4 id:60001 of https://codereview.chromium.org/1095433002/) Reason for revert: [Sheriff] Causes crashes in laout tests: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2543 Extra bisect run: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2548 Original issue's description: > Refactor compilation dependency handling. > > Extract a new data structure CompilationDependencies and move (most) logic there. > > R=mstarzinger@chromium.org,verwaest@chromium.org > BUG= > > Committed: https://crrev.com/b882479f1c84a48961b8aec81fa1bb1225034784 > Cr-Commit-Position: refs/heads/master@{#27892} TBR=mstarzinger@chromium.org,verwaest@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e3c2ba776a1796b8ea9ddc651cd5f1f0edde48c5 Cr-Commit-Position: refs/heads/master@{#27904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -248 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compilation-dependencies.h View 1 chunk +0 lines, -67 lines 0 comments Download
D src/compilation-dependencies.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M src/compiler.h View 5 chunks +34 lines, -4 lines 0 comments Download
M src/compiler.cc View 7 chunks +58 lines, -7 lines 0 comments Download
M src/hydrogen.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +15 lines, -12 lines 0 comments Download
M src/lithium.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 8 chunks +25 lines, -3 lines 0 comments Download
M src/objects.cc View 7 chunks +78 lines, -8 lines 0 comments Download
M test/cctest/test-migrations.cc View 6 chunks +22 lines, -17 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Refactor compilation dependency handling.
5 years, 8 months ago (2015-04-17 07:46:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093783002/1
5 years, 8 months ago (2015-04-17 07:47:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 07:47:23 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 07:47:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3c2ba776a1796b8ea9ddc651cd5f1f0edde48c5
Cr-Commit-Position: refs/heads/master@{#27904}

Powered by Google App Engine
This is Rietveld 408576698