Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1093763002: Revert of Make a mojo:apptests GN meta-target, add apptests. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make a mojo:apptests GN meta-target, add apptests. (patchset #3 id:60001 of https://codereview.chromium.org/1050233005/) Reason for revert: Caused compile failures (many errors, one example below) on Mac GN bot: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/7019/steps/compile/logs/stdio gen/mojo/services/html_viewer/blink_resource_map.h:37:58:error: no newline at end of file [-Werror,-Wnewline-eof] #endif // MOJO_SERVICES_HTML_VIEWER_BLINK_RESOURCE_MAP_H_ Original issue's description: > Make a mojo:apptests GN meta-target, add apptests. > > Add an apptest meta-target in mojo/BUILD.gn. > Move the apptests targets specified in src/BUILD.gn. > Add the remaining apptest targets (clipboard, VM, WM). > > Was limited to release, allow debug, but exclude component. > See gn_debug compile error from including component build in PS2: > FAILED: /b/build/slave/linux_chromium_gn/build/src/buildtools/linux64/gn --root=/b/build/slave/linux_chromium_gn/build/src -q gen //out/Debug/ > ERROR at //mojo/shell/BUILD.gn:13:1: Assertion failed. > assert(!is_component_build) > > BUG=NONE > TEST=Building mojo:apptests builds all local apptest binaries (on dbg too!). > R=sky@chromium.org > TBR=ben@chromium.org > > Committed: https://crrev.com/16b112790f541670d5f2ab97dfa70c8b89b44b1f > Cr-Commit-Position: refs/heads/master@{#325570} TBR=sky@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/69bc247eb15f6ee51521b20494267e6fe03a4762 Cr-Commit-Position: refs/heads/master@{#325575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Created Revert of Make a mojo:apptests GN meta-target, add apptests.
5 years, 8 months ago (2015-04-17 01:51:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093763002/1
5 years, 8 months ago (2015-04-17 01:51:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 01:53:06 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 01:54:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69bc247eb15f6ee51521b20494267e6fe03a4762
Cr-Commit-Position: refs/heads/master@{#325575}

Powered by Google App Engine
This is Rietveld 408576698