Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 1093713002: Revert of Send resize event when the screen info changes. (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send resize event when the screen info changes. (patchset #5 id:80001 of https://codereview.chromium.org/1078123002/) Reason for revert: Suspected as cause of flaky failures for WebViewInteractiveTest.PopupPositioningBasic WebViewInteractiveTest.PopupPositioningMoved. For details, see https://code.google.com/p/chromium/issues/detail?id=477783 Original issue's description: > Send resize event when the screen info changes. > > This is a regression from https://codereview.chromium.org/953233002 > > BUG=475939 > > Committed: https://crrev.com/6e3582ad1a058af30aa44ca7fae2113b050aa437 > Cr-Commit-Position: refs/heads/master@{#325494} TBR=danakj@chromium.org,jochen@chromium.org,piman@chromium.org,sadrul@chromium.org,sievers@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475939 Committed: https://crrev.com/b0f5046801be6f012357afbe0cffe253d1b524cf Cr-Commit-Position: refs/heads/master@{#325536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -38 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 6 chunks +9 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of Send resize event when the screen info changes.
5 years, 8 months ago (2015-04-16 22:53:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093713002/1
5 years, 8 months ago (2015-04-16 22:57:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 22:59:58 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 23:01:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0f5046801be6f012357afbe0cffe253d1b524cf
Cr-Commit-Position: refs/heads/master@{#325536}

Powered by Google App Engine
This is Rietveld 408576698