Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: runtime/vm/object.h

Issue 10937030: Make some static helpers into member functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index d92c3fe83673f62fcb616a64fb490d3606bbc95b..d4329c6bd38bd2168960d2176ba2aeb1cc71dcf4 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -3248,10 +3248,12 @@ class Integer : public Number {
// Returns 0, -1 or 1.
virtual int CompareWith(const Integer& other) const;
- static RawInteger* AsInteger(const Integer& value);
- static RawInteger* BinaryOp(Token::Kind operation,
- const Integer& left,
- const Integer& right);
+ // Return the most compact presentation of an integer.
+ RawInteger* AsInteger() const;
+ // Return an integer in the form of a RawBigint.
+ RawBigint* AsBigint() const;
+
+ RawInteger* BinaryOp(Token::Kind operation, const Integer& other) const;
OBJECT_IMPLEMENTATION(Integer, Number);
friend class Class;
@@ -3394,10 +3396,7 @@ class Bigint : public Integer {
static RawBigint* New(const String& str, Heap::Space space = Heap::kNew);
static RawBigint* New(int64_t value, Heap::Space space = Heap::kNew);
- static RawBigint* AsBigint(const Integer& value);
- static RawBigint* BinaryOp(Token::Kind operation,
- const Bigint& left,
- const Bigint& right);
+ RawBigint* BinaryOp(Token::Kind operation, const Bigint& other) const;
private:
Chunk GetChunkAt(intptr_t i) const {
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698