Do not discard selected tab

chrome/browser/chromeos/oom_priority_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/oom_priority_manager.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 212 matching lines @@
   OomMemoryDetails* details = new OomMemoryDetails();
   details->StartFetch(MemoryDetails::SKIP_USER_METRICS);
 }
 
 bool OomPriorityManager::DiscardTabById(int64 target_web_contents_id) {
   for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
        browser_iterator != BrowserList::end(); ++browser_iterator) {
     Browser* browser = *browser_iterator;
     TabStripModel* model = browser->tab_strip_model();
     for (int idx = 0; idx < model->count(); idx++) {
-      // Can't discard tabs that are already discarded.
-      if (model->IsTabDiscarded(idx))
+      // Can't discard tabs that are already discarded or selected.
+      if (model->IsTabDiscarded(idx) || model->IsTabSelected(idx))

[sky, 2012/09/24 13:56:11]

Is it the selected tab, or the active tab we care about?

Also, can we make DiscardTabContentsAt in the model do nothing if invoked for
the active tab.

[simonhong_, 2012/09/24 15:15:46]

Done.

         continue;
       WebContents* web_contents = model->GetTabContentsAt(idx)->web_contents();
       int64 web_contents_id = IdFromTabContents(web_contents);
       if (web_contents_id == target_web_contents_id) {
         LOG(WARNING) << "Discarding tab " << idx
             << " id " << target_web_contents_id;
         // Record statistics before discarding because we want to capture the
         // memory state that lead to the discard.
         RecordDiscardStatistics();
         model->DiscardTabContentsAt(idx);
@@ skipping 266 matching lines @@
         content::ZygoteHost::GetInstance()->AdjustRendererOOMScore(
             iterator->renderer_handle, score);
         pid_to_oom_score_[iterator->renderer_handle] = score;
       }
       priority += priority_increment;
     }
   }
 }
 
 }  // namespace chromeos