Source/platform/graphics/GradientGeneratedImage.h - Issue 1093673002: Removing the dependency on GraphicsContext for drawing images in 2D canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/GradientGeneratedImage.h

Issue 1093673002: Removing the dependency on GraphicsContext for drawing images in 2D canvas (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: apllied senorblanco feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/DragImageTest.cpp ('K') | « Source/platform/graphics/CrossfadeGeneratedImage.cpp ('k') | Source/platform/graphics/GradientGeneratedImage.cpp » ('j') | Source/platform/graphics/GraphicsContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/GradientGeneratedImage.h

diff --git a/Source/platform/graphics/GradientGeneratedImage.h b/Source/platform/graphics/GradientGeneratedImage.h

index 82bd42e14d231ce8615cdd15c2b8e6d19b2b91f7..220a602ebb47307d3eac98516ee3e57479bc4fa3 100644

--- a/Source/platform/graphics/GradientGeneratedImage.h

+++ b/Source/platform/graphics/GradientGeneratedImage.h

@@ -47,9 +47,8 @@ public:

}

protected:

- void draw(GraphicsContext*, const FloatRect&, const FloatRect&,

- SkXfermode::Mode, RespectImageOrientationEnum) override;

- virtual void drawTile(GraphicsContext*, const FloatRect&) final;

+ void draw(SkCanvas*, const SkPaint&, const FloatRect&, const FloatRect&, RespectImageOrientationEnum, bool shouldClampToSourceRect) override;

+ void drawTile(GraphicsContext*, const FloatRect&) final;

GradientGeneratedImage(PassRefPtr<Gradient> generator, const IntSize& size)

: GeneratedImage(size)