Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: Source/platform/graphics/BitmapImage.cpp

Issue 1093673002: Removing the dependency on GraphicsContext for drawing images in 2D canvas (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: apllied senorblanco feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/BitmapImage.cpp
diff --git a/Source/platform/graphics/BitmapImage.cpp b/Source/platform/graphics/BitmapImage.cpp
index a937da22617ae000cc3bec3b2157c5e1582a433e..2675bc576cfd60fd19cfcacb13f1e7d354bbb65f 100644
--- a/Source/platform/graphics/BitmapImage.cpp
+++ b/Source/platform/graphics/BitmapImage.cpp
@@ -280,57 +280,67 @@ String BitmapImage::filenameExtension() const
return m_source.filenameExtension();
}
-void BitmapImage::draw(GraphicsContext* ctxt, const FloatRect& dstRect, const FloatRect& srcRect, SkXfermode::Mode compositeOp, RespectImageOrientationEnum shouldRespectImageOrientation)
+bool BitmapImage::isLazyDecodedBitmap()
+{
+ SkBitmap bitmap;
+ if (!bitmapForCurrentFrame(&bitmap))
+ return false;
+ return DeferredImageDecoder::isLazyDecoded(bitmap);
+}
+
+bool BitmapImage::isImmutableBitmap()
+{
+ SkBitmap bitmap;
+ if (!bitmapForCurrentFrame(&bitmap))
+ return false;
+ return bitmap.isImmutable();
+}
+
+void BitmapImage::draw(SkCanvas* canvas, const SkPaint& paint, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum shouldRespectImageOrientation, bool shouldClampToSourceRect)
{
TRACE_EVENT0("skia", "BitmapImage::draw");
+
+ ASSERT(dstRect.width() >= 0 && dstRect.height() >= 0);
+ ASSERT(srcRect.width() >= 0 && srcRect.height() >= 0);
SkBitmap bitmap;
if (!bitmapForCurrentFrame(&bitmap))
return; // It's too early and we don't have an image yet.
- FloatRect normDstRect = adjustForNegativeSize(dstRect);
- FloatRect normSrcRect = adjustForNegativeSize(srcRect);
- normSrcRect.intersect(FloatRect(0, 0, bitmap.width(), bitmap.height()));
+ FloatRect adjustedSrcRect = srcRect;
+ adjustedSrcRect.intersect(FloatRect(0, 0, bitmap.width(), bitmap.height()));
- if (normSrcRect.isEmpty() || normDstRect.isEmpty())
+ if (adjustedSrcRect.isEmpty() || dstRect.isEmpty())
return; // Nothing to draw.
ImageOrientation orientation = DefaultImageOrientation;
if (shouldRespectImageOrientation == RespectImageOrientation)
orientation = frameOrientationAtIndex(m_currentFrame);
- GraphicsContextStateSaver saveContext(*ctxt, false);
+ int initialSaveCount = canvas->getSaveCount();
+ FloatRect adjustedDstRect = dstRect;
if (orientation != DefaultImageOrientation) {
- saveContext.save();
+ canvas->save();
// ImageOrientation expects the origin to be at (0, 0)
- ctxt->translate(normDstRect.x(), normDstRect.y());
- normDstRect.setLocation(FloatPoint());
+ canvas->translate(adjustedDstRect.x(), adjustedDstRect.y());
+ adjustedDstRect.setLocation(FloatPoint());
- ctxt->concatCTM(orientation.transformFromDefault(normDstRect.size()));
+ canvas->concat(affineTransformToSkMatrix(orientation.transformFromDefault(adjustedDstRect.size())));
if (orientation.usesWidthAsHeight()) {
// The destination rect will have it's width and height already reversed for the orientation of
// the image, as it was needed for page layout, so we need to reverse it back here.
- normDstRect = FloatRect(normDstRect.x(), normDstRect.y(), normDstRect.height(), normDstRect.width());
+ adjustedDstRect = FloatRect(adjustedDstRect.x(), adjustedDstRect.y(), adjustedDstRect.height(), adjustedDstRect.width());
}
}
- bool isLazyDecoded = DeferredImageDecoder::isLazyDecoded(bitmap);
- bool isOpaque = bitmap.isOpaque();
-
- {
- SkPaint paint;
- SkRect skSrcRect = normSrcRect;
- int initialSaveCount = ctxt->preparePaintForDrawRectToRect(&paint, skSrcRect, normDstRect, compositeOp, !isOpaque, isLazyDecoded, bitmap.isImmutable());
- // We want to filter it if we decided to do interpolation above, or if
- // there is something interesting going on with the matrix (like a rotation).
- // Note: for serialization, we will want to subset the bitmap first so we
- // don't send extra pixels.
- ctxt->drawBitmapRect(bitmap, &skSrcRect, normDstRect, &paint);
- ctxt->canvas()->restoreToCount(initialSaveCount);
- }
+ SkRect skSrcRect = adjustedSrcRect;
+ SkCanvas::DrawBitmapRectFlags flags =
+ shouldClampToSourceRect ? SkCanvas::kNone_DrawBitmapRectFlag : SkCanvas::kBleed_DrawBitmapRectFlag;
+ canvas->drawBitmapRectToRect(bitmap, &skSrcRect, adjustedDstRect, &paint, flags);
+ canvas->restoreToCount(initialSaveCount);
- if (isLazyDecoded)
+ if (DeferredImageDecoder::isLazyDecoded(bitmap))
PlatformInstrumentation::didDrawLazyPixelRef(bitmap.getGenerationID());
if (ImageObserver* observer = imageObserver())

Powered by Google App Engine
This is Rietveld 408576698