Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1093603002: Change JS parameter to camel case. (Closed)

Created:
5 years, 8 months ago by wjmaclean
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change JS parameter to camel case. Changes the parameter default_zoom_factor to appear as defaultZoomFactor to javascript. BUG=477559 Committed: https://crrev.com/f58ed8ddd7d9c58b4f42ca3986c68e061d768f8b Cr-Commit-Position: refs/heads/master@{#325477}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/tabs/zoom/popup.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
wjmaclean
kalman@ - small CL (parameter rename), ptal!
5 years, 8 months ago (2015-04-16 13:50:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093603002/1
5 years, 8 months ago (2015-04-16 13:51:28 UTC) #4
wjmaclean
I must admit, I was unsure what to do with the parameter since I didn't ...
5 years, 8 months ago (2015-04-16 13:58:45 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56805)
5 years, 8 months ago (2015-04-16 14:01:15 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093603002/20001
5 years, 8 months ago (2015-04-16 16:01:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56839)
5 years, 8 months ago (2015-04-16 16:12:08 UTC) #11
not at google - send to devlin
This isn't backwards compatible. Is the zoom API stable?
5 years, 8 months ago (2015-04-16 17:42:59 UTC) #12
wjmaclean
On 2015/04/16 17:42:59, kalman wrote: > This isn't backwards compatible. Is the zoom API stable? ...
5 years, 8 months ago (2015-04-16 17:54:17 UTC) #13
not at google - send to devlin
On 2015/04/16 17:54:17, wjmaclean wrote: > On 2015/04/16 17:42:59, kalman wrote: > > This isn't ...
5 years, 8 months ago (2015-04-16 18:03:31 UTC) #14
wjmaclean
On 2015/04/16 18:03:31, kalman wrote: > On 2015/04/16 17:54:17, wjmaclean wrote: > > On 2015/04/16 ...
5 years, 8 months ago (2015-04-16 18:05:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093603002/20001
5 years, 8 months ago (2015-04-16 18:06:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 18:15:38 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:16:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f58ed8ddd7d9c58b4f42ca3986c68e061d768f8b
Cr-Commit-Position: refs/heads/master@{#325477}

Powered by Google App Engine
This is Rietveld 408576698