Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1093563002: Componentize strings used by //chrome/browser/undo (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger, sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@injection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize strings used by //chrome/browser/undo IDS_BOOKMARK_BAR_??DO* strings are used by //chrome/browser/undo and thus must be componentized. Move them to components_strings target. Update tools/gritsettings/resource_ids so that strings do not overlap with components resources. BUG=476920 Committed: https://crrev.com/5ec59f44b501ca90731a2cdf734b05f33c5f8723 Cr-Commit-Position: refs/heads/master@{#325607}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Update //components/OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -75 lines) Patch
M chrome/app/bookmarks_strings.grdp View 2 chunks +0 lines, -72 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/undo/undo_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
A components/undo_strings.grdp View 1 chunk +82 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
sdefresne
droger: can you take a look? sky: OWNERS approval
5 years, 8 months ago (2015-04-16 09:32:03 UTC) #2
droger
lgtm https://codereview.chromium.org/1093563002/diff/1/tools/gritsettings/resource_ids File tools/gritsettings/resource_ids (right): https://codereview.chromium.org/1093563002/diff/1/tools/gritsettings/resource_ids#newcode110 tools/gritsettings/resource_ids:110: "messages": [12500], Probably not for this CL, but ...
5 years, 8 months ago (2015-04-16 09:42:10 UTC) #3
sky
LGTM
5 years, 8 months ago (2015-04-16 15:54:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093563002/40001
5 years, 8 months ago (2015-04-16 20:54:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/43560) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-16 21:02:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093563002/40001
5 years, 8 months ago (2015-04-17 06:55:48 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-17 07:42:41 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 07:43:42 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ec59f44b501ca90731a2cdf734b05f33c5f8723
Cr-Commit-Position: refs/heads/master@{#325607}

Powered by Google App Engine
This is Rietveld 408576698