Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1093433004: X87: VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: VectorICs: megamorphic keyed loads in crankshaft don't need a vector. port 776770c0e4e9cffad408581962ca90f247ac66f0 (r27827). original commit message: This needs "Pass load ic state through the Oracle" (https://codereview.chromium.org/1083933002/) to land first. BUG= Committed: https://crrev.com/e481c91b641edb730677a745c31ccdb92dee6180 Cr-Commit-Position: refs/heads/master@{#27873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-16 07:01:36 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-16 09:38:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093433004/1
5 years, 8 months ago (2015-04-16 09:38:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 10:02:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 10:03:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e481c91b641edb730677a745c31ccdb92dee6180
Cr-Commit-Position: refs/heads/master@{#27873}

Powered by Google App Engine
This is Rietveld 408576698