Generate thumbnails except when IO error of metadata fetch.

Generate thumbnails except when IO error of metadata fetch.

Previously we haven't generated thumbnails if an error had happened to avoid showing (and caching) wrongly rotated thubmanil (crbug.com/463384).
This CL changes to generate thumbnail even an error had happend.
However, IO error is an exception since IO error may not happen in the next try.

BUG=475251
TEST=manually tested.

Committed: https://crrev.com/961d607cd9c43d377d274a07f535aa61d49e5420
Cr-Commit-Position: refs/heads/master@{#325399}

[yawano, 2015-04-16 05:59:31]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2015-04-16 05:59:31]

PTAL. Thank you!

[fukino, 2015-04-16 06:56:56]

Thanks!
Why is a fixed issue(463384) listed in the BUG=?

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js
(right):

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:411:
ListThumbnailLoader.Task.EXIF_PARSER_IO_ERROR_MESSAGE
Please make this @private or use this string directly.

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:426: ===
ListThumbnailLoader.Task.EXIF_PARSER_IO_ERROR_MESSAGE)
I thinks === is usually put at the end of line.

[yawano, 2015-04-16 07:05:59]

I added crbug.com/463384 since it explains the background of this issue clearly.
I moved it to the description of the CL. PTAL. Thank you!

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js
(right):

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:411:
ListThumbnailLoader.Task.EXIF_PARSER_IO_ERROR_MESSAGE
On 2015/04/16 06:56:56, fukino wrote:
> Please make this @private or use this string directly.

Done.

https://codereview.chromium.org/1093433003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:426: ===
ListThumbnailLoader.Task.EXIF_PARSER_IO_ERROR_MESSAGE)
On 2015/04/16 06:56:56, fukino wrote:
> I thinks === is usually put at the end of line.

Done.

[fukino, 2015-04-16 07:10:36]

LGTM. Thanks!

[yawano, 2015-04-16 07:21:10]

On 2015/04/16 07:10:36, fukino wrote:
> LGTM. Thanks!

Thank you!

[yawano, 2015-04-16 07:21:13]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-04-16 07:21:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093433003/20001

[commit-bot: I haz the power, 2015-04-16 07:53:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 07:54:55]

Patchset 2 (id:??) landed as
https://crrev.com/961d607cd9c43d377d274a07f535aa61d49e5420
Cr-Commit-Position: refs/heads/master@{#325399}