Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1093433002: html_viewer: Add a mock WebNotificationManager. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

html_viewer: Add a mock WebNotificationManager. Huffington Post websites check that they have permission to pop up notifications. If we don't have this mock version, we crash. BUG=none Committed: https://crrev.com/473278a10064f7a6c682b210017f8158a7000f52 Cr-Commit-Position: refs/heads/master@{#325349}

Patch Set 1 #

Total comments: 3

Patch Set 2 : sky nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/webnotificationmanager_impl.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/webnotificationmanager_impl.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
https://codereview.chromium.org/1093433002/diff/1/mojo/services/html_viewer/webnotificationmanager_impl.cc File mojo/services/html_viewer/webnotificationmanager_impl.cc (right): https://codereview.chromium.org/1093433002/diff/1/mojo/services/html_viewer/webnotificationmanager_impl.cc#newcode58 mojo/services/html_viewer/webnotificationmanager_impl.cc:58: return blink::WebNotificationPermission(); This is the function that gets called ...
5 years, 8 months ago (2015-04-15 23:10:01 UTC) #2
sky
LGTM https://codereview.chromium.org/1093433002/diff/1/mojo/services/html_viewer/BUILD.gn File mojo/services/html_viewer/BUILD.gn (right): https://codereview.chromium.org/1093433002/diff/1/mojo/services/html_viewer/BUILD.gn#newcode79 mojo/services/html_viewer/BUILD.gn:79: "webnotificationmanager_impl.cc", I don't get our naming of these ...
5 years, 8 months ago (2015-04-15 23:17:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093433002/20001
5 years, 8 months ago (2015-04-15 23:23:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 23:49:13 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:54:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/473278a10064f7a6c682b210017f8158a7000f52
Cr-Commit-Position: refs/heads/master@{#325349}

Powered by Google App Engine
This is Rietveld 408576698