Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1093423003: Android's Clang toolchain can't assemble the JPEG's .S files. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
Tom Hudson, mtklein
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Android's Clang toolchain can't assemble the JPEG's .S files. Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d8afd50b5aed11e47280606e14f49a96b4288298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
5 years, 8 months ago (2015-04-21 18:56:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093423003/1
5 years, 8 months ago (2015-04-21 19:00:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 19:06:36 UTC) #6
mtklein
lgtm
5 years, 8 months ago (2015-04-21 19:07:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093423003/1
5 years, 8 months ago (2015-04-21 19:07:29 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 19:07:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d8afd50b5aed11e47280606e14f49a96b4288298

Powered by Google App Engine
This is Rietveld 408576698