Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1093413002: VectorICs: support converting keyed loads into named loads in crankshaft. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: support converting keyed loads into named loads in crankshaft. This was a TODO for a while in crankshaft, now ready to address. BUG= R=mstarzinger@chromium.org Committed: https://crrev.com/3099c34851c669860749059637826f4678d7eb9c Cr-Commit-Position: refs/heads/master@{#27976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M src/hydrogen.cc View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Michael, here it is for Crankshaft
5 years, 8 months ago (2015-04-21 15:30:41 UTC) #1
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-04-21 15:32:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093413002/1
5 years, 8 months ago (2015-04-21 15:38:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 16:03:31 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3099c34851c669860749059637826f4678d7eb9c
Cr-Commit-Position: refs/heads/master@{#27976}

Powered by Google App Engine
This is Rietveld 408576698