Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1093383003: Remove mainthread overhang painting code (Closed)

Created:
5 years, 8 months ago by Xianzhu
Modified:
5 years, 8 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, shans, rjwright, darktears, Mike Lawther (Google), blink-reviews-animation_chromium.org, dshwang, slimming-paint-reviews_chromium.org, dstockwell, Timothy Loh, Steve Block, gavinp+loader_chromium.org, blink-reviews-paint_chromium.org, Nate Chapin, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove mainthread overhang painting code The original intent was to make overhang painting code work for slimming-paint, but finally found that the code is not being used. BUG=476143 R=ccameron@chromium.org TBR=chrishtr@chromium.org (passive changes under web/ and platform/) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -331 lines) Patch
M Source/core/frame/FrameView.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +0 lines, -83 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/paint/FramePainter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/paint/FramePainter.cpp View 2 chunks +0 lines, -31 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollableAreaTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarTheme.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarTheme.cpp View 3 chunks +3 lines, -32 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 chunk +0 lines, -134 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/web/ScrollbarGroup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ScrollbarGroup.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Xianzhu
5 years, 8 months ago (2015-04-21 18:01:18 UTC) #2
ccameron
lgtm Was some of that code recently added? I remembered deleting everything that was behind ...
5 years, 8 months ago (2015-04-21 18:08:33 UTC) #3
Xianzhu
On 2015/04/21 18:08:33, ccameron wrote: > lgtm > > Was some of that code recently ...
5 years, 8 months ago (2015-04-21 18:13:07 UTC) #4
ccameron
On 2015/04/21 18:13:07, Xianzhu wrote: > On 2015/04/21 18:08:33, ccameron wrote: > > lgtm > ...
5 years, 8 months ago (2015-04-21 18:18:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093383003/1
5 years, 8 months ago (2015-04-21 19:31:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/31789)
5 years, 8 months ago (2015-04-21 19:41:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093383003/1
5 years, 8 months ago (2015-04-21 21:21:31 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 21:25:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194166

Powered by Google App Engine
This is Rietveld 408576698