[Webapp Refactor] Cleans up the ClientSession.EventHandler interface.

remoting/webapp/crd/js/it2me_activity.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
@@ skipping 56 matching lines @@
 };
 
 remoting.It2MeActivity.prototype.stop = function() {
   this.desktopActivity_.stop();
 };
 
 /**
  * @param {!remoting.Error} error
  */
 remoting.It2MeActivity.prototype.onConnectionFailed = function(error) {
-  this.onError(error);
+  this.showErrorMessage_(error);
+  base.dispose(this.desktopActivity_);
+  this.desktopActivity_ = null;
 };
 
 /**
  * @param {!remoting.ConnectionInfo} connectionInfo
  */
 remoting.It2MeActivity.prototype.onConnected = function(connectionInfo) {
   this.accessCodeDialog_.inputField().value = '';
 };
 
-remoting.It2MeActivity.prototype.onDisconnected = function() {
-  this.showFinishDialog_(remoting.AppMode.CLIENT_SESSION_FINISHED_IT2ME);
+remoting.It2MeActivity.prototype.onDisconnected = function(error) {
+  if (error.isNone()) {
+    this.showFinishDialog_(remoting.AppMode.CLIENT_SESSION_FINISHED_IT2ME);
+  } else {
+    this.showErrorMessage_(error);
+  }
+
+  base.dispose(this.desktopActivity_);
+  this.desktopActivity_ = null;
 };
 
 /**
  * @param {!remoting.Error} error
+ * @private
  */
-remoting.It2MeActivity.prototype.onError = function(error) {
+remoting.It2MeActivity.prototype.showErrorMessage_ = function(error) {
   var errorDiv = document.getElementById('connect-error-message');
   l10n.localizeElementFromTag(errorDiv, error.getTag());
   this.showFinishDialog_(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
 };
 
 /** @return {remoting.DesktopRemotingActivity} */
 remoting.It2MeActivity.prototype.getDesktopActivityForTesting = function() {
   return this.desktopActivity_;
 };
 
@@ skipping 95 matching lines @@
   switch (error) {
     case 0: return new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE);
     case 404: return new remoting.Error(remoting.Error.Tag.INVALID_ACCESS_CODE);
     case 502: // No break
     case 503: return new remoting.Error(remoting.Error.Tag.SERVICE_UNAVAILABLE);
     default: return remoting.Error.unexpected();
   }
 }
 
 })();