[Webapp Refactor] Cleans up the ClientSession.EventHandler interface.

remoting/webapp/crd/js/desktop_remoting_activity.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
@@ skipping 70 matching lines @@
   if (connectionInfo.plugin().hasCapability(
           remoting.ClientSession.Capability.VIDEO_RECORDER)) {
     var recorder = new remoting.VideoFrameRecorder();
     connectionInfo.plugin().extensions().register(recorder);
     this.connectedView_.setVideoFrameRecorder(recorder);
   }
 
   this.parentActivity_.onConnected(connectionInfo);
 };
 
-remoting.DesktopRemotingActivity.prototype.onDisconnected = function() {
-  this.parentActivity_.onDisconnected();
-  this.dispose();
+remoting.DesktopRemotingActivity.prototype.onDisconnected = function(reason) {
+  if (this.handleError_(reason)) {
+    return;
+  }
+  this.parentActivity_.onDisconnected(reason);
 };
 
 /**
  * @param {!remoting.Error} error
  */
 remoting.DesktopRemotingActivity.prototype.onConnectionFailed =
     function(error) {
+  if (this.handleError_(error)) {
+    return;
+  }
   this.parentActivity_.onConnectionFailed(error);
 };
 
 /**
  * @param {!remoting.Error} error The error to be localized and displayed.
+ * @return {boolean} returns true if the error is handled.
+ * @private
  */
-remoting.DesktopRemotingActivity.prototype.onError = function(error) {
-  console.error('Connection failed: ' + error.toString());
-
+remoting.DesktopRemotingActivity.prototype.handleError_ = function(error) {
   if (error.hasTag(remoting.Error.Tag.AUTHENTICATION_FAILED)) {
     remoting.setMode(remoting.AppMode.HOME);
     remoting.handleAuthFailureAndRelaunch();
-    return;
+    return true;
   }
-
-  this.parentActivity_.onError(error);
-
-  this.dispose();
+  return false;
 };
 
 remoting.DesktopRemotingActivity.prototype.dispose = function() {
   base.dispose(this.connectedView_);
   this.connectedView_ = null;
   base.dispose(this.session_);
   this.session_ = null;
 };
 
 /** @return {remoting.DesktopConnectedView} */
 remoting.DesktopRemotingActivity.prototype.getConnectedView = function() {
   return this.connectedView_;
 };
 
 /**
  * @return {remoting.ClientSession}.
  */
 remoting.DesktopRemotingActivity.prototype.getSession = function() {
   return this.session_;
 };
 
 })();