Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: remoting/webapp/crd/js/client_session_unittest.js

Issue 1093373005: [Webapp Refactor] Cleans up the ClientSession.EventHandler interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 6
7 'use strict'; 7 'use strict';
8 8
9 /** @type {remoting.MockConnection} */ 9 /** @type {remoting.MockConnection} */
10 var mockConnection; 10 var mockConnection;
11 /** @type {remoting.ClientSession} */ 11 /** @type {remoting.ClientSession} */
12 var session; 12 var session;
13 /** @type {remoting.ClientSession.EventHandler} */ 13 /** @type {remoting.ClientSession.EventHandler} */
14 var listener; 14 var listener;
15 /** @type {sinon.TestStub} */ 15 /** @type {sinon.TestStub} */
16 var logToServerStub; 16 var logToServerStub;
17 17
18 /** 18 /**
19 * @constructor 19 * @constructor
20 * @implements {remoting.ClientSession.EventHandler} 20 * @implements {remoting.ClientSession.EventHandler}
21 */ 21 */
22 var SessionListener = function() {}; 22 var SessionListener = function() {};
23 SessionListener.prototype.onConnectionFailed = function(error) {}; 23 SessionListener.prototype.onConnectionFailed = function(error) {};
24 SessionListener.prototype.onConnected = function(connectionInfo) {}; 24 SessionListener.prototype.onConnected = function(connectionInfo) {};
25 SessionListener.prototype.onDisconnected = function() {}; 25 SessionListener.prototype.onDisconnected = function(error) {};
26 SessionListener.prototype.onError = function(error) {};
27 26
28 /** 27 /**
29 * @param {remoting.ClientSession.ConnectionError=} opt_error 28 * @param {remoting.ClientSession.ConnectionError=} opt_error
30 * @return {Promise} 29 * @return {Promise}
31 */ 30 */
32 function connect(opt_error) { 31 function connect(opt_error) {
33 var deferred = new base.Deferred(); 32 var deferred = new base.Deferred();
34 var host = new remoting.Host('fake_hostId'); 33 var host = new remoting.Host('fake_hostId');
35 host.jabberId = 'fake_jid'; 34 host.jabberId = 'fake_jid';
36 35
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 }); 134 });
136 }); 135 });
137 136
138 QUnit.test( 137 QUnit.test(
139 'Connection error after CONNECTED should raise the CONNECTION_DROPPED event', 138 'Connection error after CONNECTED should raise the CONNECTION_DROPPED event',
140 function(assert) { 139 function(assert) {
141 140
142 var State = remoting.ClientSession.State; 141 var State = remoting.ClientSession.State;
143 142
144 return connect().then(function() { 143 return connect().then(function() {
145 var onError = sinon.stub(listener, 'onError'); 144 var onDisconnected = sinon.stub(listener, 'onDisconnected');
146 session.disconnect(new remoting.Error(remoting.Error.Tag.P2P_FAILURE)); 145 session.disconnect(new remoting.Error(remoting.Error.Tag.P2P_FAILURE));
147 assert.equal(onError.callCount, 1); 146 assert.equal(onDisconnected.callCount, 1);
148 assert.equal(logToServerStub.args[2][0], State.CONNECTION_DROPPED); 147 assert.equal(logToServerStub.args[2][0], State.CONNECTION_DROPPED);
149 }); 148 });
150 }); 149 });
151 150
152 QUnit.test( 151 QUnit.test(
153 'Connection error before CONNECTED should raise the CONNECTION_FAILED event', 152 'Connection error before CONNECTED should raise the CONNECTION_FAILED event',
154 function(assert) { 153 function(assert) {
155 154
156 session.logHostOfflineErrors(true); 155 session.logHostOfflineErrors(true);
157 156
(...skipping 10 matching lines...) Expand all
168 }); 167 });
169 }); 168 });
170 169
171 QUnit.test('dispose() should dispose the plugin', function(assert) { 170 QUnit.test('dispose() should dispose the plugin', function(assert) {
172 var pluginDispose = sinon.stub(mockConnection.plugin(), 'dispose'); 171 var pluginDispose = sinon.stub(mockConnection.plugin(), 'dispose');
173 session.dispose(); 172 session.dispose();
174 assert.equal(pluginDispose.callCount, 1); 173 assert.equal(pluginDispose.callCount, 1);
175 }); 174 });
176 175
177 })(); 176 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698