Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1093373005: [Webapp Refactor] Cleans up the ClientSession.EventHandler interface. (Closed)

Created:
5 years, 8 months ago by kelvinp
Modified:
5 years, 8 months ago
Reviewers:
Jamie, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Cleans up the ClientSession.EventHandler interface. This CL provides a cleaner way to report session state changes with the following: 1. Removes onError() callback on ClientSession Handler. Instead, if an error is encountered before the session connects, onConnectionFailed() will be called, and similarly, onDisconnected() will be called for errors encountered after a session is connected. 2. Removes the sessionStateChanged event on clientSession, so session state are reported consistently through the ClientSession.EventHandler interface. BUG=477522 Committed: https://crrev.com/79a9a66e3152beef0545632aa30315456f2ebe74 Cr-Commit-Position: refs/heads/master@{#326853}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -87 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 2 chunks +16 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/client_session.js View 7 chunks +15 lines, -36 lines 1 comment Download
M remoting/webapp/crd/js/client_session_factory_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/client_session_unittest.js View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting_activity.js View 2 chunks +13 lines, -11 lines 0 comments Download
M remoting/webapp/crd/js/it2me_activity.js View 2 chunks +14 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/me2me_activity.js View 2 chunks +18 lines, -6 lines 0 comments Download
M remoting/webapp/crd/js/smart_reconnector.js View 3 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kelvinp
PTAL
5 years, 8 months ago (2015-04-23 18:58:22 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1093373005/diff/1/remoting/webapp/crd/js/client_session.js File remoting/webapp/crd/js/client_session.js (right): https://codereview.chromium.org/1093373005/diff/1/remoting/webapp/crd/js/client_session.js#newcode272 remoting/webapp/crd/js/client_session.js:272: return; This appears in both your CLs.
5 years, 8 months ago (2015-04-24 18:09:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093373005/1
5 years, 8 months ago (2015-04-24 18:22:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 19:09:56 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 19:10:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79a9a66e3152beef0545632aa30315456f2ebe74
Cr-Commit-Position: refs/heads/master@{#326853}

Powered by Google App Engine
This is Rietveld 408576698