Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1093363002: Refactor DartTypeVisitor and ElementVisitor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 58904818d0e55005fe7d326daa411b915fa5e338..ead0798e98c26018afd86fc3db4e79747774a096 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -6894,9 +6894,7 @@ class TypeBuilder implements DartTypeVisitor<dynamic, SsaBuilder> {
TypeBuilder(this.classWorld);
- void visitType(DartType type, _) {
- throw 'Internal error $type';
- }
+ void apply(DartType type, SsaBuilder builder) => type.accept(this, builder);
floitsch 2015/04/21 13:10:34 visit
Johnni Winther 2015/04/21 13:37:05 Done.
void visitVoidType(VoidType type, SsaBuilder builder) {
ClassElement cls = builder.backend.findHelper('VoidRuntimeType');
@@ -6956,10 +6954,6 @@ class TypeBuilder implements DartTypeVisitor<dynamic, SsaBuilder> {
throw 'not implemented visitStatementType($type)';
}
- void visitGenericType(GenericType type, SsaBuilder builder) {
- throw 'not implemented visitGenericType($type)';
- }
-
void visitInterfaceType(InterfaceType type, SsaBuilder builder) {
List<HInstruction> inputs = <HInstruction>[];
for (DartType typeArgument in type.typeArguments) {

Powered by Google App Engine
This is Rietveld 408576698