Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1093313003: Revert of Update lists of compile targets for the GN bots. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update lists of compile targets for the GN bots. (patchset #2 id:20001 of https://codereview.chromium.org/1106853002/) Reason for revert: Broke chromium.webkit "Linux GN (dbg)", http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN%20(dbg)/builds/12991 Original issue's description: > Update lists of compile targets for the GN bots. > > Previously most of the GN bots were explicitly building > "all", which is a lot more than we build on the (non-clobber) > GYP bots. > > This patch syncs the lists so that we build the same targets the > GYP bots build as much as possible (in some cases the targets > don't work yet for GYP). > > This also will workaround a bug in MB where building "all" bypasses > analyze. > > R=phajdan.jr@chromium.org > BUG=461019, 480643 > CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg > > Committed: https://crrev.com/a5319cfb4311320aa80dbc48fdc0b24192262439 > Cr-Commit-Position: refs/heads/master@{#326948} TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461019, 480643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -861 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 2 chunks +2 lines, -96 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +2 lines, -101 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +2 lines, -52 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +2 lines, -102 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +2 lines, -106 lines 0 comments Download
M testing/buildbot/client.v8.json View 1 chunk +1 line, -51 lines 0 comments Download
M testing/buildbot/manage.py View 1 chunk +1 line, -5 lines 0 comments Download
M testing/buildbot/tryserver.blink.json View 1 chunk +1 line, -48 lines 0 comments Download
M testing/buildbot/tryserver.chromium.linux.json View 4 chunks +4 lines, -197 lines 0 comments Download
M testing/buildbot/tryserver.chromium.mac.json View 2 chunks +2 lines, -52 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +1 line, -51 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Created Revert of Update lists of compile targets for the GN bots.
5 years, 8 months ago (2015-04-25 15:20:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093313003/1
5 years, 8 months ago (2015-04-25 15:20:22 UTC) #2
commit-bot: I haz the power
Failed to apply patch for testing/buildbot/tryserver.chromium.linux.json: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-25 15:20:42 UTC) #4
sof
Failed to apply due to not taking https://codereview.chromium.org/1055403009 into account also.
5 years, 8 months ago (2015-04-25 15:32:21 UTC) #6
Dirk Pranke
5 years, 8 months ago (2015-04-25 16:00:07 UTC) #7
I (should) have fixed the problem in https://codereview.chromium.org/1104913002/
, so hopefully we don't need this.

Sorry for the breakage, and thanks for trying to fix things!

Powered by Google App Engine
This is Rietveld 408576698