chrome/browser/system_monitor/removable_device_notifications_linux.cc - Issue 10933114: Combine boolean MediaDeviceNotifications histograms to an enumerated histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_linux.cc

Issue 10933114: Combine boolean MediaDeviceNotifications histograms to an enumerated histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/system_monitor/removable_device_notifications_chromeos.cc ('k') | chrome/browser/system_monitor/removable_device_notifications_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/system_monitor/removable_device_notifications_linux.cc

diff --git a/chrome/browser/system_monitor/removable_device_notifications_linux.cc b/chrome/browser/system_monitor/removable_device_notifications_linux.cc

index 2d484dc9d7721c2a47e4dc6393829fe7e89b313d..c6b56de239b305b69fe641893471c719c515e05f 100644

--- a/chrome/browser/system_monitor/removable_device_notifications_linux.cc

+++ b/chrome/browser/system_monitor/removable_device_notifications_linux.cc

@@ -435,12 +435,8 @@ void RemovableDeviceNotificationsLinux::AddNewMount(

bool removable;

get_device_info_func_(mount_device, &unique_id, &name, &removable);

- // Keep track of device uuid, to see how often we receive empty values.

- UMA_HISTOGRAM_BOOLEAN("MediaDeviceNotification.DeviceUUIDAvailable",

- !unique_id.empty());

- UMA_HISTOGRAM_BOOLEAN("MediaDeviceNotification.DeviceNameAvailable",

- !name.empty());

+ // Keep track of device info details to see how often we get invalid values.

+ MediaStorageUtil::RecordDeviceInfoHistogram(true, unique_id, name);

if (unique_id.empty() || name.empty())

return;