chrome/browser/system_monitor/removable_device_notifications_mac.mm - Issue 10933114: Combine boolean MediaDeviceNotifications histograms to an enumerated histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_mac.mm

Issue 10933114: Combine boolean MediaDeviceNotifications histograms to an enumerated histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/system_monitor/removable_device_notifications_linux.cc ('K') | « chrome/browser/system_monitor/removable_device_notifications_linux.cc ('k') | chrome/browser/system_monitor/removable_device_notifications_window_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/system_monitor/removable_device_notifications_mac.mm

diff --git a/chrome/browser/system_monitor/removable_device_notifications_mac.mm b/chrome/browser/system_monitor/removable_device_notifications_mac.mm

index 85455e6a9ee9605c431db01c8093148700b868b0..29ac0c2db9aeca70e9dfd00fc7893e3a2482148f 100644

--- a/chrome/browser/system_monitor/removable_device_notifications_mac.mm

+++ b/chrome/browser/system_monitor/removable_device_notifications_mac.mm

@@ -4,6 +4,7 @@

#include "chrome/browser/system_monitor/removable_device_notifications_mac.h"

+#include "chrome/browser/system_monitor/removable_device_notifications_histogram.h"

#include "content/public/browser/browser_thread.h"

namespace chrome {

@@ -96,6 +97,8 @@ void RemovableDeviceNotificationsMac::UpdateDisk(

disk_info_map_.erase(it);

} else {

disk_info_map_[info.bsd_name()] = info;

+ RecordDeviceInfoHistogram(info.type(), info.device_id(),

+ info.display_name());

if (ShouldPostNotificationForDisk(info)) {

base::SystemMonitor::Get()->ProcessRemovableStorageAttached(

info.device_id(), info.display_name(), info.mount_point().value());