Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 10933113: x11: Unset the X11 error handlers when the message-loop starts getting destroyed. (Closed)

Created:
8 years, 3 months ago by sadrul
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

x11: Unset the X11 error handlers when the message-loop starts getting destroyed. The X11 error handlers report the errors from a PostTask()ed function, but since the X11 error may have happened when the message-loop was already getting destroyed (e.g. the message-pump destructor), this can cause errors. BUG=146928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157056

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +8 lines, -0 lines 1 comment Download
M chrome/browser/chrome_browser_main_x11.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_x11.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
http://codereview.chromium.org/10933113/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/10933113/diff/1/chrome/browser/chrome_browser_main.cc#newcode1478 chrome/browser/chrome_browser_main.cc:1478: UnsetBrowserX11ErrorHandlers(); I considered doing this from ChromeBrowserMainPartsLinux::PostMainMessageLoopRun. However, since ...
8 years, 3 months ago (2012-09-16 16:32:33 UTC) #1
sky
8 years, 3 months ago (2012-09-16 18:48:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698