Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10933103: fix build break (Closed)

Created:
8 years, 3 months ago by tburkard
Modified:
8 years, 3 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -13 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/load_time_stats.h View 1 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/net/load_time_stats.cc View 1 4 chunks +99 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tburkard
8 years, 3 months ago (2012-09-14 20:36:46 UTC) #1
cbentzel
8 years, 3 months ago (2012-09-14 21:18:37 UTC) #2
Lgtm

From virtual keyboard, sorry for typos.
On Sep 14, 2012 4:36 PM, <tburkard@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> fix build break
> R=cbentzel@chromium.org
>
> Please review this at
https://codereview.chromium.**org/10933103/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     chrome/browser/net/load_time_**stats.cc
>
>
> Index: chrome/browser/net/load_time_**stats.cc
> ==============================**==============================**=======
> --- chrome/browser/net/load_time_**stats.cc       (revision 156872)
> +++ chrome/browser/net/load_time_**stats.cc       (working copy)
> @@ -179,9 +179,8 @@
>
>  class LoadTimeStats::URLRequestStats {
>   public:
> -  explicit URLRequestStats(LoadTimeStats* load_time_stats)
> -      : load_time_stats_(load_time_**stats),
> -        done_(false),
> +  URLRequestStats()
> +      : done_(false),
>          start_time_(GetCurrentTime()),
>          status_(REQUEST_STATUS_ACTIVE) {
>    }
> @@ -250,7 +249,6 @@
>    base::TimeTicks GetCurrentTime() {
>      return base::TimeTicks::Now();
>    }
> -  LoadTimeStats* load_time_stats_;
>    bool done_;
>    base::TimeTicks start_time_;
>    RequestStatus status_;
> @@ -333,7 +331,7 @@
>    RequestStatsMap::const_**iterator it = request_stats_.find(request);
>    if (it != request_stats_.end())
>      return it->second;
> -  URLRequestStats* new_request_stats = new URLRequestStats(this);
> +  URLRequestStats* new_request_stats = new URLRequestStats();
>    request_stats_[request] = new_request_stats;
>    return new_request_stats;
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698