Issue 10933087: Consistently use named getters for Lithium operands on x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10933087: Consistently use named getters for Lithium operands on x64 (Closed)

Created:
8 years, 3 months ago by Sven Panne

Modified:
8 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Consistently use named getters for Lithium operands on x64 Committed: https://code.google.com/p/v8/source/detail?r=12508

Patch Set 2 : Addressed review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+411 lines, -237 lines)			Patch
M	src/x64/lithium-codegen-x64.cc	View		84 chunks	+131 lines, -131 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1	96 chunks	+260 lines, -86 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		5 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). https://chromiumcodereview.appspot.com/10933087/diff/1/src/x64/lithium-x64.h File src/x64/lithium-x64.h (right): https://chromiumcodereview.appspot.com/10933087/diff/1/src/x64/lithium-x64.h#newcode1561 src/x64/lithium-x64.h:1561: DECLARE_CONCRETE_INSTRUCTION(OuterContext, "outer-context") Move this macro ...

8 years, 3 months ago (2012-09-14 09:58:56 UTC) #2

Sven Panne

8 years, 3 months ago (2012-09-14 11:45:50 UTC) #3

Landing...

http://codereview.chromium.org/10933087/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/10933087/diff/1/src/x64/lithium-x64.h#newcode1561
src/x64/lithium-x64.h:1561: DECLARE_CONCRETE_INSTRUCTION(OuterContext,
"outer-context")
On 2012/09/14 09:58:56, Michael Starzinger wrote:
> Move this macro below the operand accessors.

Done.

Expand Messages | Collapse Messages

Issue 10933087: Consistently use named getters for Lithium operands on x64 (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages