Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

Issue 10933085: Update ConstrainedWindowViews appearance according to mock (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Button layout and appearance updates Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
diff --git a/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc b/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
index b78a6422f02952c5e53e91d55389e4904968ae24..e99975c6f60ee813bdd99cc682b82d450f8e530c 100644
--- a/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
+++ b/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/views/tab_modal_confirm_dialog_views.h"
+#include "base/command_line.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/browser_list.h"
@@ -11,9 +12,11 @@
#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
+#include "chrome/common/chrome_switches.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/views/controls/message_box_view.h"
+#include "ui/views/window/dialog_client_view.h"
namespace chrome {
@@ -25,6 +28,29 @@ void ShowTabModalConfirmDialog(TabModalConfirmDialogDelegate* delegate,
} // namespace chrome
+namespace {
+const int kWebStyleUniformInset = 0;
+const int kWebStyleInterRowVerticalSpacing = 20;
+
+views::MessageBoxView::InitParams CreateMessageBoxViewInitParams(
+ const string16& message)
+{
+ views::MessageBoxView::InitParams params(message);
+
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kEnableFramelessConstrainedDialogs)) {
+ params.top_inset = kWebStyleUniformInset;
+ params.bottom_inset = kWebStyleUniformInset;
+ params.left_inset = kWebStyleUniformInset;
+ params.right_inset = kWebStyleUniformInset;
+
+ params.inter_row_vertical_spacing = kWebStyleInterRowVerticalSpacing;
+ }
+
+ return params;
+}
+} // namespace
+
//////////////////////////////////////////////////////////////////////////////
// TabModalConfirmDialogViews, constructor & destructor:
@@ -33,7 +59,7 @@ TabModalConfirmDialogViews::TabModalConfirmDialogViews(
TabContents* tab_contents)
: delegate_(delegate),
message_box_view_(new views::MessageBoxView(
- views::MessageBoxView::InitParams(delegate->GetMessage()))) {
+ CreateMessageBoxViewInitParams(delegate->GetMessage()))) {
delegate_->set_window(new ConstrainedWindowViews(tab_contents, this));
}
@@ -66,6 +92,16 @@ bool TabModalConfirmDialogViews::Accept() {
return true;
}
+views::ClientView* TabModalConfirmDialogViews::CreateClientView(
+ views::Widget* widget) {
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kEnableFramelessConstrainedDialogs))
+ return new views::DialogClientView(
+ widget, GetContentsView(), views::DialogClientView::STYLE_WEB);
+
+ return DialogDelegate::CreateClientView(widget);
+}
+
///////////////////////////////////////////////////////////////////////////////
// TabModalConfirmDialogViews, views::WidgetDelegate implementation:

Powered by Google App Engine
This is Rietveld 408576698