Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 10933083: Remove deprecated gfx::Image::operator NSImage*(). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
index d7c8b5f4ad2ae6df9402c2d81e49cbeda0bf280c..b1e8331305dd48bef09edb4f681a7e5ef61412cb 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
@@ -573,14 +573,16 @@ NSCursor* LoadWebKitCursor(WebKit::WebCursorInfo::Type type) {
return;
NSImage* iconImage =
- ResourceBundle::GetSharedInstance().GetNativeImageNamed(IDR_THROBBER);
+ ResourceBundle::GetSharedInstance().GetNativeImageNamed(
+ IDR_THROBBER).ToNSImage();
icon = [ThrobberView filmstripThrobberViewWithFrame:iconFrame
image:iconImage];
} else {
- gfx::Image page_icon = windowShim_->panel()->GetCurrentPageIcon();
+ const gfx::Image& page_icon = windowShim_->panel()->GetCurrentPageIcon();
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
NSImage* iconImage = page_icon.IsEmpty() ?
- rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON) : page_icon.ToNSImage();
+ rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON).ToNSImage() :
+ page_icon.ToNSImage();
NSImageView* iconView =
[[[NSImageView alloc] initWithFrame:iconFrame] autorelease];
[iconView setImage:iconImage];

Powered by Google App Engine
This is Rietveld 408576698