Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 10933055: Revert "Clean up android_webview build scripts" (Closed)

Created:
8 years, 3 months ago by Yaron
Modified:
8 years, 3 months ago
Reviewers:
cjhopman, Torne
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "Clean up android_webview build scripts" This reverts commit 66d0377aa771760773c270cffdb634f765aeb1ba. Breaks clean builds: http://build.chromium.org/p/tryserver.chromium/builders/android/builds/36124/steps/compile/logs/stdio TBR=cjhopman@chromium.org,torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -81 lines) Patch
M android_webview/android_webview.gyp View 3 chunks +173 lines, -78 lines 0 comments Download
M android_webview/java/android_webview_apk.xml View 1 chunk +6 lines, -1 line 0 comments Download
M android_webview/javatests/android_webview_test_apk.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yaron
8 years, 3 months ago (2012-09-12 20:38:55 UTC) #1
Torne
8 years, 3 months ago (2012-09-12 20:50:48 UTC) #2
lgtm, sorry, this looked reasonable when i reviewed it :)

Powered by Google App Engine
This is Rietveld 408576698