Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/ui/webui/instant_ui.cc

Issue 10933023: Control zero suggest with a pref, not a switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/instant_ui.cc
diff --git a/chrome/browser/ui/webui/instant_ui.cc b/chrome/browser/ui/webui/instant_ui.cc
index e066dc591e91950a6bf18439082ffc4189224acf..033cdc9f95315fda3a4bba4e04beaaa65ccd44b8 100644
--- a/chrome/browser/ui/webui/instant_ui.cc
+++ b/chrome/browser/ui/webui/instant_ui.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/webui/instant_ui.h"
#include "base/bind.h"
+#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
#include "chrome/common/pref_names.h"
@@ -75,36 +76,45 @@ void InstantUIMessageHandler::GetPreferenceValue(const base::ListValue* args) {
std::string pref_name;
if (!args->GetString(0, &pref_name)) return;
- double value = 0.0;
+ base::StringValue pref_name_value(pref_name);
+ if (pref_name == prefs::kInstantAnimationScaleFactor) {
+ double value = 0.0;
#if defined(TOOLKIT_VIEWS)
- if (pref_name == prefs::kInstantAnimationScaleFactor)
value = slow_animation_scale_factor_;
#endif
-
- base::StringValue arg1(pref_name);
- base::FundamentalValue arg2(value);
- web_ui()->CallJavascriptFunction(
- "instantConfig.getPreferenceValueResult",
- arg1,
- arg2);
+ web_ui()->CallJavascriptFunction(
+ "instantConfig.getPreferenceValueResult",
+ pref_name_value,
+ base::FundamentalValue(value));
+ } else if (pref_name == prefs::kExperimentalZeroSuggestUrlPrefix) {
+ PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
+ web_ui()->CallJavascriptFunction(
+ "instantConfig.getPreferenceValueResult",
+ pref_name_value,
+ base::StringValue(prefs->GetString(pref_name.c_str())));
+ }
}
void InstantUIMessageHandler::SetPreferenceValue(const base::ListValue* args) {
std::string pref_name;
if (!args->GetString(0, &pref_name)) return;
- double value;
- if (!args->GetDouble(1, &value)) return;
-
-#if defined(TOOLKIT_VIEWS)
if (pref_name == prefs::kInstantAnimationScaleFactor) {
+ double value;
+ if (!args->GetDouble(1, &value)) return;
+#if defined(TOOLKIT_VIEWS)
// Clamp to something reasonable.
value = std::max(0.1, std::min(value, 10.0));
slow_animation_scale_factor_ = static_cast<int>(value);
- }
#else
- NOTIMPLEMENTED();
+ NOTIMPLEMENTED();
#endif
+ } else if (pref_name == prefs::kExperimentalZeroSuggestUrlPrefix) {
+ std::string value;
+ if (!args->GetString(1, &value)) return;
+ PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
+ prefs->SetString(pref_name.c_str(), value);
+ }
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698