Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 1093243002: getElementsByName returns HtmlCollection on IE (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: un-suppress passing tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/dartmetadata.py
diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py
index 5d11efb81c222df0d30df701a8298d4d1b1d13f2..3e16cf72d5f19a4a2474403f02bf2812f5b81567 100644
--- a/tools/dom/scripts/dartmetadata.py
+++ b/tools/dom/scripts/dartmetadata.py
@@ -60,7 +60,7 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Creates('Null')",
],
- # Normally Window is nevernull, but starting from a <template> element in
+ # Normally Window is never null, but starting from a <template> element in
# JavaScript, this will be null:
# template.content.ownerDocument.defaultView
'Document.window': [
@@ -68,12 +68,17 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('Window|=Object|Null')",
],
- 'Document.getElementsByTagName': [
+ 'Document.getElementsByClassName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
- 'Document.getElementsByClassName': [
+ 'Document.getElementsByName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'Document.getElementsByTagName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
@@ -98,12 +103,17 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('JSExtendableArray')",
],
- 'Element.getElementsByTagName': [
+ 'Element.getElementsByClassName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
- 'Element.getElementsByClassName': [
+ 'Element.getElementsByName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'Element.getElementsByTagName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
@@ -280,12 +290,17 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@annotation_Returns_SerializedScriptValue",
],
- 'ShadowRoot.getElementsByTagName': [
+ 'ShadowRoot.getElementsByClassName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
- 'ShadowRoot.getElementsByClassName': [
+ 'ShadowRoot.getElementsByName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'ShadowRoot.getElementsByTagName': [
"@Creates('NodeList|HtmlCollection')",
"@Returns('NodeList|HtmlCollection')",
],
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698