third_party/libaddressinput/chromium/cpp/test/retriever_test.cc - Issue 109323011: [rac] Download all rules for a country code in libaddressinput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

Issue 109323011: [rac] Download all rules for a country code in libaddressinput. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add a TODO. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

diff --git a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

index 15674fe4d91742c029f92649c191d14eff8b431d..c5f445b4c7fe074b1a1f2019a8837b73640214d8 100644

--- a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

+++ b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

@@ -142,10 +142,7 @@ TEST_F(RetrieverTest, RequestsDontStack) {

EXPECT_FALSE(success_);

EXPECT_TRUE(key_.empty());

-#if !defined(NDEBUG)

- // This request should cause an assert.

- ASSERT_DEATH(slow_retriever.Retrieve(kKey, BuildCallback()), "");

-#endif

+ EXPECT_NO_FATAL_FAILURE(slow_retriever.Retrieve(kKey, BuildCallback()));

}

} // namespace