[es6] Map/Set size getter should have "get size" name

src/runtime/runtime-function.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
 #include "src/arguments.h"
 #include "src/compiler.h"
 #include "src/cpu-profiler.h"
@@ skipping 58 matching lines @@
 
 
 static Handle<String> NameToFunctionName(Handle<Name> name) {
   Handle<String> stringName(name->GetHeap()->empty_string());
 
   // TODO(caitp): Follow proper rules in section 9.2.11 (SetFunctionName)
   if (name->IsSymbol()) {
     Handle<Object> description(Handle<Symbol>::cast(name)->name(),
                                name->GetIsolate());
     if (description->IsString()) {
-      stringName = Handle<String>::cast(description);
+      return Handle<String>::cast(description);
     }
   } else {
-    stringName = Handle<String>::cast(name);
+    return String::Flatten(Handle<String>::cast(name));
   }
 
   return stringName;
 }
 
 
 RUNTIME_FUNCTION(Runtime_FunctionSetName) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 2);
 
   CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0);
   CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
 
-  f->shared()->set_name(*NameToFunctionName(name));
+  // NameToFunctionName may cause allocations so we need to be careful about

[adamk, 2015/04/24 16:29:07]

Not sure this comment adds much, I'd tend to expect that functions dealing in
handles might allocate (basically the old code was already bad form).

+  // execution order here.
+  name = NameToFunctionName(name);
+  f->shared()->set_name(*name);
   return isolate->heap()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(Runtime_FunctionNameShouldPrintAsAnonymous) {
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_CHECKED(JSFunction, f, 0);
   return isolate->heap()->ToBoolean(
       f->shared()->name_should_print_as_anonymous());
@@ skipping 535 matching lines @@
 
 
 RUNTIME_FUNCTION(Runtime_IsFunction) {
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_CHECKED(Object, obj, 0);
   return isolate->heap()->ToBoolean(obj->IsJSFunction());
 }
 }
 }  // namespace v8::internal