Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 the V8 project authors. All rights reserved. | 1 // Copyright 2014 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "src/v8.h" | 5 #include "src/v8.h" |
| 6 | 6 |
| 7 #include "src/accessors.h" | 7 #include "src/accessors.h" |
| 8 #include "src/arguments.h" | 8 #include "src/arguments.h" |
| 9 #include "src/compiler.h" | 9 #include "src/compiler.h" |
| 10 #include "src/cpu-profiler.h" | 10 #include "src/cpu-profiler.h" |
| (...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 72 Handle<String> stringName(name->GetHeap()->empty_string()); | 72 Handle<String> stringName(name->GetHeap()->empty_string()); |
| 73 | 73 |
| 74 // TODO(caitp): Follow proper rules in section 9.2.11 (SetFunctionName) | 74 // TODO(caitp): Follow proper rules in section 9.2.11 (SetFunctionName) |
| 75 if (name->IsSymbol()) { | 75 if (name->IsSymbol()) { |
| 76 Handle<Object> description(Handle<Symbol>::cast(name)->name(), | 76 Handle<Object> description(Handle<Symbol>::cast(name)->name(), |
| 77 name->GetIsolate()); | 77 name->GetIsolate()); |
| 78 if (description->IsString()) { | 78 if (description->IsString()) { |
| 79 stringName = Handle<String>::cast(description); | 79 stringName = Handle<String>::cast(description); |
| 80 } | 80 } |
| 81 } else { | 81 } else { |
| 82 stringName = Handle<String>::cast(name); | 82 stringName = String::Flatten(Handle<String>::cast(name)); |
| 83 } | 83 } |
| 84 | 84 |
| 85 return stringName; | 85 return stringName; |
| 86 } | 86 } |
| 87 | 87 |
| 88 | 88 |
| 89 RUNTIME_FUNCTION(Runtime_FunctionSetName) { | 89 RUNTIME_FUNCTION(Runtime_FunctionSetName) { |
| 90 HandleScope scope(isolate); | 90 HandleScope scope(isolate); |
| 91 DCHECK(args.length() == 2); | 91 DCHECK(args.length() == 2); |
| 92 | 92 |
| 93 CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0); | 93 CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0); |
| 94 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); | 94 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); |
| 95 | 95 |
| 96 f->shared()->set_name(*NameToFunctionName(name)); | 96 f->shared()->set_name(*NameToFunctionName(name)); |
|
adamk
2015/04/24 16:06:53
The solution is to put this on two lines:
name =
| |
| 97 return isolate->heap()->undefined_value(); | 97 return isolate->heap()->undefined_value(); |
| 98 } | 98 } |
| 99 | 99 |
| 100 | 100 |
| 101 RUNTIME_FUNCTION(Runtime_FunctionNameShouldPrintAsAnonymous) { | 101 RUNTIME_FUNCTION(Runtime_FunctionNameShouldPrintAsAnonymous) { |
| 102 SealHandleScope shs(isolate); | 102 SealHandleScope shs(isolate); |
| 103 DCHECK(args.length() == 1); | 103 DCHECK(args.length() == 1); |
| 104 CONVERT_ARG_CHECKED(JSFunction, f, 0); | 104 CONVERT_ARG_CHECKED(JSFunction, f, 0); |
| 105 return isolate->heap()->ToBoolean( | 105 return isolate->heap()->ToBoolean( |
| 106 f->shared()->name_should_print_as_anonymous()); | 106 f->shared()->name_should_print_as_anonymous()); |
| (...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 642 | 642 |
| 643 | 643 |
| 644 RUNTIME_FUNCTION(Runtime_IsFunction) { | 644 RUNTIME_FUNCTION(Runtime_IsFunction) { |
| 645 SealHandleScope shs(isolate); | 645 SealHandleScope shs(isolate); |
| 646 DCHECK(args.length() == 1); | 646 DCHECK(args.length() == 1); |
| 647 CONVERT_ARG_CHECKED(Object, obj, 0); | 647 CONVERT_ARG_CHECKED(Object, obj, 0); |
| 648 return isolate->heap()->ToBoolean(obj->IsJSFunction()); | 648 return isolate->heap()->ToBoolean(obj->IsJSFunction()); |
| 649 } | 649 } |
| 650 } | 650 } |
| 651 } // namespace v8::internal | 651 } // namespace v8::internal |
| OLD | NEW |