Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1093183004: Reland "Remove the weak list of views from array buffers" (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Remove the weak list of views from array buffers" Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f Cr-Commit-Position: refs/heads/master@{#28029}

Patch Set 1 #

Patch Set 2 : hydrogen / ic support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+620 lines, -880 lines) Patch
M src/accessors.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 2 chunks +31 lines, -21 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +27 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/elements.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/elements.cc View 8 chunks +22 lines, -14 lines 0 comments Download
M src/factory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/factory.cc View 5 chunks +86 lines, -11 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/heap/heap.h View 5 chunks +0 lines, -32 lines 0 comments Download
M src/heap/heap.cc View 8 chunks +1 line, -29 lines 0 comments Download
M src/heap/objects-visiting.cc View 4 chunks +0 lines, -79 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 6 chunks +4 lines, -24 lines 0 comments Download
M src/hydrogen.h View 1 3 chunks +27 lines, -16 lines 0 comments Download
M src/hydrogen.cc View 1 15 chunks +123 lines, -54 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.h View 16 chunks +47 lines, -51 lines 0 comments Download
M src/objects.cc View 4 chunks +122 lines, -134 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/objects-inl.h View 2 chunks +78 lines, -20 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 6 chunks +0 lines, -62 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 2 chunks +0 lines, -295 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
ptal the first patch set is the original version the second patch set adds the ...
5 years, 8 months ago (2015-04-23 12:09:31 UTC) #1
dcarney
lgtm
5 years, 8 months ago (2015-04-23 12:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093183004/20001
5 years, 8 months ago (2015-04-23 12:21:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 13:02:59 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f Cr-Commit-Position: refs/heads/master@{#28029}
5 years, 8 months ago (2015-04-23 13:03:15 UTC) #7
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-24 06:46:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1053203007/ by jochen@chromium.org.

The reason for reverting is: still working on perf.

Powered by Google App Engine
This is Rietveld 408576698