Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1093183003: Function scopes only must have a context if they call sloppy eval (Closed)

Created:
5 years, 8 months ago by wingo
Modified:
5 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Function scopes only must have a context if they call sloppy eval A strict arrow function with no parameters and no variable bindings won't need a context object because it will never have any locals. (This is unlike strict normal functions, which do have "arguments" and "this" locals.) R=rossberg@chromium.org BUG=v8:4056 LOG=N Committed: https://crrev.com/d5fd58165c5348c45e3a63d60df9d75787b44e83 Cr-Commit-Position: refs/heads/master@{#28031}

Patch Set 1 #

Patch Set 2 : Fix ScopeInfo context slot calculation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/scopeinfo.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/harmony/regress/regress-4056.js View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
wingo
5 years, 8 months ago (2015-04-23 11:30:50 UTC) #1
rossberg
lgtm
5 years, 8 months ago (2015-04-23 11:54:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093183003/1
5 years, 8 months ago (2015-04-23 12:06:48 UTC) #4
wingo
On 2015/04/23 12:06:48, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-23 12:26:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5093)
5 years, 8 months ago (2015-04-23 12:31:47 UTC) #7
wingo
On 2015/04/23 12:31:47, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-23 12:47:04 UTC) #8
rossberg
lgtm
5 years, 8 months ago (2015-04-23 12:56:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093183003/20001
5 years, 8 months ago (2015-04-23 12:57:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 13:20:15 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 13:20:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5fd58165c5348c45e3a63d60df9d75787b44e83
Cr-Commit-Position: refs/heads/master@{#28031}

Powered by Google App Engine
This is Rietveld 408576698